Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix NPE in ReferenceBuilder#tryRecoverTypeArguments #3737

Merged
merged 1 commit into from
Dec 22, 2020
Merged

fix: fix NPE in ReferenceBuilder#tryRecoverTypeArguments #3737

merged 1 commit into from
Dec 22, 2020

Conversation

sibwaf
Copy link
Contributor

@sibwaf sibwaf commented Dec 21, 2020

ReferenceBuilder#tryRecoverTypeArguments doesn't check whether expectedType.typeArguments() is null and crashes with an NPE. Could be a bug in JDT, but the check nevertheless should be there - ParameterizedTypeBinding has a lot of null-checks for this field.

@monperrus monperrus changed the title review: fix: Null pointer in ReferenceBuilder#tryRecoverTypeArguments fix: fix NPE in ReferenceBuilder#tryRecoverTypeArguments Dec 22, 2020
@monperrus monperrus merged commit 4223c68 into INRIA:master Dec 22, 2020
@monperrus
Copy link
Collaborator

Thanks a lot for your contribution @dya-tel

@sibwaf sibwaf deleted the FixNullInReferenceBuilder branch December 22, 2020 15:41
@monperrus monperrus mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sibwaf @monperrus